search

pythonforfacebook / djangobook

10 stars 4 forks source link

Clean up enabled/disabled paths #3

Open aidanlister opened 13 years ago

aidanlister commented 13 years ago

I don't think the DISABLED/ENABLED paths stuff is very useful.

For example DJANGOBOOK_DISABLED_PATHS = [r'^admin/'] does nothing because the browser pulls favicon.ico as well.

Any ideas how we can do it better?

jgorset commented 13 years ago

I don't think the DISABLED/ENABLED paths stuff is very useful. For example DJANGOBOOK_DISABLED_PATHS = [r'^admin/'] does nothing because the browser pulls favicon.ico as well.

DJANGOBOOK_ENABLED_PATHS and DJANGOBOOK_DISABLED_PATHS were implemented so one would not be redirected to renew the access token (see middleware.py, line 67) upon accessing Django applications that aren't part of the Facebook application (e.g. django.contrib.admin).

It would be great if we could eliminate the aforementioned redirect altogether, but I don't know how else one might retrieve a new access token from a canvas application.

aidanlister commented 13 years ago

Ahh of course, I didn't think about the redirect. Interesting problem for which I don't have a suggestion!