pythongosssss / ComfyUI-Custom-Scripts

Enhancements & experiments for ComfyUI, mostly focusing on UI features
MIT License
1.38k stars 104 forks source link

Update imageFeed.js #224

Closed tachyon-beep closed 2 weeks ago

tachyon-beep commented 3 months ago

This is a (somewhat over the top) rewrite of the Image Feed system based on my previous abandoned pull request.

The feed:

Additionally, the slider for height as well as two new controls have been moved to the ComfyUI menu.

Locking the feed to the left or right has not yet been implemented but I can readd it if its a 'must go' feature. Known 'image nodes' are defined in an array, with unrecognised nodes caught via a catch fall filter setting. I'm currently looking for a better way to identify 'image' nodes for inclusion in the filter.

Tested on Firefox and Chromium.

tachyon-beep commented 3 months ago

The big weakness of this implementation is that I haven't found a way to dynamically identify 'image' nodes. There's a 'custom node' fallback, but this is deeply unsatisfying.

All feedback is welcome, but feedback on that issue specifically is extra welcome.

pythongosssss commented 3 months ago

Hey, thanks, would you please be able to split the different parts into their own PRs (probably: batch markers, filtering nodes, ui refactor changes), as its difficult to review with everything all in one.

For some early feedback: