pythongosssss / ComfyUI-Custom-Scripts

Enhancements & experiments for ComfyUI, mostly focusing on UI features
MIT License
1.37k stars 104 forks source link

Math Expression stopped doing correct math with division and floats. #252

Closed 49RpK5dY closed 1 month ago

49RpK5dY commented 1 month ago

20240517_0254 ss

Node on the bottom give an error:

Error occurred when executing MathExpression|pysssss:

'Call' object has no attribute 'op'

  File "/sd/ComfyUI/execution.py", line 151, in recursive_execute
    output_data, output_ui = get_output_data(obj, input_data_all)
  File "/sd/ComfyUI/execution.py", line 81, in get_output_data
    return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
  File "/sd/ComfyUI/execution.py", line 74, in map_node_over_list
    results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
  File "/sd/ComfyUI/custom_nodes/ComfyUI-Custom-Scripts/py/math_expression.py", line 227, in evaluate
    r = eval_expr(node)
  File "/sd/ComfyUI/custom_nodes/ComfyUI-Custom-Scripts/py/math_expression.py", line 204, in eval_expr
    args.append(eval_expr(arg))
  File "/sd/ComfyUI/custom_nodes/ComfyUI-Custom-Scripts/py/math_expression.py", line 171, in eval_expr
    return eval_op(node.left, node.right)
  File "/sd/ComfyUI/custom_nodes/ComfyUI-Custom-Scripts/py/math_expression.py", line 165, in eval_op
    return operators[type(node.op)](l, r)
PrometheusDante commented 1 month ago

Untitled-2

It's a little worse than that I'm afraid :D

pythongosssss commented 1 month ago

This should now be resolved, apologies shouldnt push before going to sleep 😴

49RpK5dY commented 1 month ago

Yep. Works great as before. Thanks.