pythongosssss / ComfyUI-Custom-Scripts

Enhancements & experiments for ComfyUI, mostly focusing on UI features
MIT License
1.87k stars 144 forks source link

ShowText Node is no longer displaying text. #364

Open lord-lethris opened 1 month ago

lord-lethris commented 1 month ago

Updated ComfyUI, and now the ShowText Node is no longer displaying text.

workflow (23)

It is however passing text though.

workflow (24)

Its just not showing the text in the ShowText Node's Display like it use to anymore.

Beatboxace commented 1 month ago

Hi, I've been having the same problem. I investigated and debugged a bit, and here is a few pointers: If you are using DeepFuze custom node, there seem to be a conflict as stated here On the frontend side, when ShowText is done receiving input to display, it goes into nodeType.prototype.onExecuted from showText.js. This executes:

onExecuted?.apply(this, arguments);
populate.call(this, message.text);

The first line seems to wrongly trigger their function from DeepFuze's preview_audio.js

nodeType.prototype.onExecuted = function (data) {
    previewAudio(this, data.audio[0], data.audio[1]);
}

Which results in an error (as we aren't trying to preview audio or anything, the data value passed is null). When such errors occur, I think comfyUI handles it by using a break, which stops the execution, thus not displaying the text through populate.call.

Possible solutions

Hope it helps!

lord-lethris commented 1 month ago

That has indeed helped. you are a star Mr @Beatboxace

I hope DeepFuze gets a fix for it then.

DeepFuze has caused a number of issues with users I see, their requirement file uninstalls newer dependencies and replaces them with MUCH older ones.

Even me, personally, I had to re-install ONNX, Torch and XFormers after DeepFuze ballsed them up.

Or... We just stop using DeepFuze :(

Yanquansu commented 1 month ago

I have same issue even I didn't installed the DeepFuze

Xenodimensional commented 1 week ago

I have this same issue and don't have DeepFuze installed. I hope the dev can fix it. Does anyone know of any other nodes that have the same functionality?

Yanquansu commented 1 week ago

hello! Your letter I have received, thanks!