pythongssapi / python-gssapi

A Python interface to RFC 2743/2744 (plus common extensions)
ISC License
104 stars 46 forks source link

Undocumented units of time #277

Closed judilsteve closed 2 years ago

judilsteve commented 2 years ago

I cannot find a single mention of a unit of time in the documentation of the high level API.

E.g. I can acquire a credential and I know that it has a lifetime of "36000"; a value which is totally useless because I don't know if it's 36000 seconds, milliseconds, minutes, hours, millenia?

jborean93 commented 2 years ago

I'm pretty sure the lifetime values for both the security context and credential are measured in seconds. For example gss_acquire_cred time_req states

Integer, read, optional number of seconds that credentials should remain valid. Specify GSS_C_INDEFINITE to request that the credentials have the maximum permitted lifetime.

The gss_init_sec_context call also mentions the same. Will have to update the documentation when I get a chance. Feel free to send through a PR if you find some time.

judilsteve commented 2 years ago

https://github.com/pythongssapi/python-gssapi/pull/278

jborean93 commented 2 years ago

Fixed with https://github.com/pythongssapi/python-gssapi/pull/285