search

pythongssapi / python-gssapi

A Python interface to RFC 2743/2744 (plus common extensions)
ISC License
104 stars 46 forks source link

Change sdist and build to use PEP517 #296

Closed jborean93 closed 2 years ago

jborean93 commented 2 years ago

Changes the sdist to no longer include the cythonised .c files and rely on the PEP517 features to define Cython as a build requirement. This ensures that when building this package from the sdist, the process will include any bugfixes for Cython that have been fixed after the python-gssapi version has been released.

The removal of the .c files also simplifies the setup.py by removing more functionality that was tied specifically to setuptools or even distutils making it more flexible for the future.

The CI process has been updated to test against this new artifact rather than testing against an build_ext --inplace instance to better replicate how end users will be using the library.

Fixes: https://github.com/pythongssapi/python-gssapi/issues/294

Signed-off-by: Jordan Borean jborean93@gmail.com

jborean93 commented 2 years ago

@simo5 just an FYI on this change. It's fairly large as it changes how CI works but the bulk of the stuff is moving to a PEP 517 compliant setup which allows us to simplify the sdist and wheel creation steps.

Let me know if you wish to review this or have a look through. I'm hoping to merge it in by the end of the week.