search

pythongssapi / python-gssapi

A Python interface to RFC 2743/2744 (plus common extensions)
ISC License
103 stars 45 forks source link

Update setup.py #331

Closed sanglist closed 8 months ago

sanglist commented 10 months ago

Small fix to enable vas_gssapi Signed-off-by: Shlomo Anglister shlomo.anglister@intel.com

github-actions[bot] commented 9 months ago

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

sanglist commented 9 months ago

Please merge to resolve setup issue

simo5 commented 9 months ago

@jborean93 this patch looks sane enough, ok if I merge it?

jborean93 commented 9 months ago

Sorry this one was lost in my sea of notifications. At a glance it seems ok but I do wonder if it might potentially pick up some false positive match with some options where we may want to be a bit more selective for this particular scenario.

sanglist commented 9 months ago

Sorry this one was lost in my sea of notifications. At a glance it seems ok but I do wonder if it might potentially pick up some false positive match with some options where we may want to be a bit more selective for this particular scenario.

Agreed but - it's a bug fix Would appreciate you improving it.

jborean93 commented 9 months ago

I only want to approve it when I know it won't break other use cases. What setup is causing the problem here is it a specific distro/package. What is the output of krb5-config --libs gssapi, is there potentially a better way of fixing your problem.

sanglist commented 9 months ago

I only want to approve it when I know it won't break other use cases. What setup is causing the problem here, what is the output of krb5-config --libs gssapi and is there potentially a better way of fixing your problem.

On SLES12 (SuSE 12 Enterprise)

-Wl,-rpath,/opt/quest/lib64:/opt/quest/lib64/support -L/opt/quest/lib64 -lvas -L/opt/quest/lib64/support -lgcc_s -lvas-gssapi -lrt -lresolv

jborean93 commented 9 months ago

Thanks, is vas-gssapi just a SLES thing or is it a specific package here? I'm afraid I'm not familiar with it.

sanglist commented 9 months ago

It depends on corporate, right ? bridging all kinds of authentication protocols originating from a vast application space to corporate authentication.

jborean93 commented 9 months ago

What I’m trying to get at is how can I test out this scenario. If I need to maintain this I need to know who could be affected and what scenarios this code needs to handle. Do you have any info on this vas-gssapi library. Is it a product I can install or is it a paid product. Are there docs online about it that you can share.

sanglist commented 9 months ago

The solution at: pykrb5/setup.py Seems to provide a one size fits all using environment variables.

github-actions[bot] commented 8 months ago

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.