search

pythongssapi / requests-gssapi

An authentication handler for using GSSAPI with Python Requests. Drop-in replacement for old requests-kerberos.
Other
32 stars 21 forks source link

Last fixups before release #6

Closed frozencemetery closed 6 years ago

frozencemetery commented 6 years ago

These were encountered when running the mod_auth_gssapi test suite against the shim interface. I replaced all import requests_kerberos there with import requests_gssapi and performed no other action, so it tested only the shim interface. It may be good to add a CI item for doing this on a regular basis going forward.

Also this is the last thing on my TODO list before release.

simo5 commented 6 years ago

(after you fix the failing test)

frozencemetery commented 6 years ago

Thanks. The failing tests have to do with python3 and the bytes/strings/unicode nonsense. It interacts very poorly with the base64 module.

simo5 commented 6 years ago

Yep, I know, I had 'fun' back in the time maing jwcrypto tests.py work in both python2 and python3, look at that one for inspiration if you need some :)

frozencemetery commented 6 years ago

Thanks. Should be good to go now I think.