use posframe to show documentation

pythonic-emacs / anaconda-mode

Code navigation, documentation lookup and completion for Python.

GNU General Public License v3.0

707 stars 87 forks source link

use posframe to show documentation #364

Closed nicehiro closed 4 years ago

proofit404 commented 5 years ago

Hi, thanks for your contribution!

Should it be melpa dependency?
Should it be configured to use it or not?
What would happen if posframe isn't available?

Best regards, Artem.

nicehiro commented 5 years ago

Hi, thanks for your contribution!

Should it be melpa dependency?

Should it be configured to use it or not?

What would happen if posframe isn't available?

Best regards, Artem.

Hi, your work was really help me a lot!

Yes, this is repo
If someone want to use posframe to show doc, just set anaconda-mode-use-posframe-show-doc to t
Just like old one.

Hope you can test before merging it.

screenshot:

proofit404 commented 5 years ago

BTW https://twitter.com/proofit404/status/1171919301789593601

CeleritasCelery commented 4 years ago

Thanks. This looks really nice.

brtsay commented 4 years ago

The versions of posframe on GNU and MELPA require Emacs 26, so this does (might?) break anaconda-mode for anyone using Emacs 25 (the built-in emacs for Ubuntu 18.04 LTS) or below and installing via list-packages

CeleritasCelery commented 4 years ago

That is a fair point. But installing the package will not cause any issues unless you try to actually execute it. And since it is off by default we should be okay to leave the minimum emacs version at 25.

brtsay commented 4 years ago

Thanks for the quick reply! There may be something off with my config, but anaconda-mode now shows up as an incompatible package for me using Emacs 25 due to its posframe dependency

CeleritasCelery commented 4 years ago

Oh that is an problem. Would you please open a new issue so we can track this properly?

brtsay commented 4 years ago

Got it, I opened up an issue #367