search

pythonic-emacs / anaconda-mode

Code navigation, documentation lookup and completion for Python.
GNU General Public License v3.0
707 stars 87 forks source link

Fix bad xref-pop-to-location call #366

Closed Watkurem closed 5 years ago

Watkurem commented 5 years ago

Emacs commit 4f479aeb4b13d640df21b4943beb0935f75b5126 changed the API and broke M-. .

proofit404 commented 5 years ago

Thanks!

BTW https://twitter.com/proofit404/status/1171919301789593601

proofit404 commented 5 years ago

Does this change will affect released emacs versions?

Watkurem commented 5 years ago

Hello! Not sure I'm qualified to do elisp maintaining :D Just noticed the commit I'm referencing is not in any release yet. I'd expect it will break anaconda-mode for them, so I'm probably way too early with this PR.

Should I change it to something like (funcall (if (fboundp 'xref-pop-to-location) 'xref-pop-to-location 'xref--pop-to-location)) ...), or is this PR completely irrelevant for now?

CeleritasCelery commented 5 years ago

it’s not too early. Many people build from the latest release. The wrapper you suggested will work. Please make that change and this can be merged in.

Watkurem commented 5 years ago

I added the if fbound wrapper and it works for my emacs-git build