Closed enikar closed 1 year ago
Thanks. I change the commit message slightly and fixed the typo in is_jedi_dep_satistied
.
Since you didn't create a feature branch for this PR I couldn't force push my commits to your branch and github doesn't know it's merged.
But your change is in master: https://github.com/pythonic-emacs/anaconda-mode/commit/ca8edbaa7662d97e4a4416ec9a8d743863303911
Thanks.
Sorry, I'm not confortable with github and the procedure used. I don't know you you meant by saying:
Since you didn't create a feature branch for this PR
No problem. It is a bit confusing if you're only used to the original email+patch workflow.
Normally you would create a new branch in your fork where you make your changes.
Then when you make a PR, I can push changes myself to your branch (if some checkbox is ticked, which it is by default).
But your branch was named master
which is also the default branch name in this repo which meant I couldn't
checkout your PR with your branch name since master
already exists and I also couldn't push the changes back to your branch.
But all in all it doesn't matter too much, so all good :)
tl;dr It's better to create a feature branch for each PR you make.
Thanks for the explanation, I'll try to remember that the next time I'll make a PR :)
To compare the two version, I just use a simple method. See the function: jedi_dep_is_satisfied()