search

pythonic-emacs / anaconda-mode

Code navigation, documentation lookup and completion for Python.
GNU General Public License v3.0
706 stars 87 forks source link

Add eldoc compliance #428

Closed biscanli closed 1 year ago

biscanli commented 1 year ago

The goal here is to make anaconda-eldoc work with other packages that support eldoc such as flymake, etc. I have tested the code on Emacs 29. It works with different eldoc modes like compose-eagerly and default.

dakra commented 1 year ago

Thanks. Is this compatible with older Emacs version?

(I use Emacs 30 from the master branch myself, so the change works for me.)

biscanli commented 1 year ago

A quick check on Emacs 27 also worked. I cannot think of a way to test anything before, but as long as eldoc-documentation-functions exists, it should be compatible.

dakra commented 1 year ago

Thanks.

I also didn't test this properly with older Emacs versions. But it looks good and works with my Emacs version, so hopefully it's good for everyone else too.