pythonicrubyist / creek

Ruby library for parsing large Excel files.
http://rubygems.org/gems/creek
MIT License
388 stars 109 forks source link

Remove http requirement and replace with OpenURI #87

Closed dbernheisel closed 4 years ago

dbernheisel commented 4 years ago

Related #81 and Resolves #80

There were no tests for parsing remote files, so I added them but wasn't sure where to find a good online sample. I googled for some public files that fit two scenarios, and excluded these tests from running by default since they hit the internet.

This removes the http gem dependency and replaces it with Ruby's stdlib open-uri

Also, running rake failed for me because it didn't have require 'time', so I added that.

pythonicrubyist commented 4 years ago

Thanks for your contribution.