search

pythonicrubyist / creek

Ruby library for parsing large Excel files.
http://rubygems.org/gems/creek
MIT License
386 stars 109 forks source link

Added mapping cell ids with header column name #93

Closed dimaaleks closed 4 years ago

dimaaleks commented 4 years ago

What?

Added possibility to map cells with header column name.

To be able to have smth like 

 {"OVERRIDE_ID"=>123,
  "Renewal_Month"=>"April",
  "OVERRIDE_YNFLAG"=>"N",
  "CLIENT_ID"=>123,
  "CLIENT_NAME"=>"OOYALA INC",
  "SET_ID"=>123,
  "DESCRIPTION"=>"20-21 GLExcess 19-20 WC"}

instead of

 {"A"=>123,
  "B"=>"April",
  "C"=>"N",
  "D"=>123,
  "E"=>"OOYALA INC",
  "F"=>123,
  "G"=>"20-21 GLExcess 19-20 WC"}
dimaaleks commented 4 years ago

@pythonicrubyist hey man! hope you have a great day! Can you pls take a look and say how can we proceed with these changes?

pythonicrubyist commented 4 years ago

@dimaaleks thanks for your contribution. The code looks good. Can you please add a unit test for this new feature? Once the unit test is added, I will merge the PR and release a new gem version. Thanks.

dimaaleks commented 4 years ago

@pythonicrubyist tests were added, pls check. Thanks in advance!

dimaaleks commented 4 years ago

@pythonicrubyist hey man! sorry for being annoying but could you pls send some feedback :)

dimaaleks commented 4 years ago

@pythonicrubyist hey man! still need your review, thanks in advance!