search

pythonindia / inpycon2017

PyCon India 2017 Website, staging site from master branch is available at https://pythonindia.github.io/inpycon2017
29 stars 55 forks source link

[UX/UI] Icon overlaps "Buy Tickets" button on mobile view #90

Closed realslimshanky closed 7 years ago

realslimshanky commented 7 years ago

Below is the screenshot of the issue. This can be fixed my making the button size smaller for mobile view. image

withshubh commented 7 years ago

Fixed!

realslimshanky commented 7 years ago

@withshubh, here are few things I reviewed. 1) You have created two separate branches with same fix on both of them. Only one is enough. 2) You'll have send PR (Pull Request) from either of the branches of your forked repository to the master branch of original repository. 3) Your fix has made the icon look smaller on the desktop version of website as well. The bug is only on the mobile view. You'll have to use media queries in your css to target only the mobile view. Feel free to question in case of any confusion.

realslimshanky commented 7 years ago

@CuriousLearner this can be closed and the issue is resolved and merged in #95