pythonindia / inpycon2017

PyCon India 2017 Website, staging site from master branch is available at https://pythonindia.github.io/inpycon2017
29 stars 55 forks source link

[Fix #72] Hero screen size for all viewports #92

Closed sagarchoudhary96 closed 1 year ago

sagarchoudhary96 commented 7 years ago

screenshot from 2017-08-03 12-11-24

The hero screen was overflowing on mobile screens so i made it's height to 100vh so that it looks same on all devices. Below is the updated screenshot:

screenshot from 2017-08-03 12-15-13

sagarchoudhary96 commented 7 years ago

you can view the updated version here.

sagarchoudhary96 commented 7 years ago

@theskumar fixed the conflicts and provided live version link too

sagarchoudhary96 commented 7 years ago

@realslimshanky @theskumar please see to it

realslimshanky commented 7 years ago

@sagarchoudhary96 problem with your fix is that it'll now work with the screen with small devices. All the buttons get cramped into little space on the screen and it does not look good. Exhibit A image

sagarchoudhary96 commented 7 years ago

@realslimshanky but i think it looks better and the button were having that much magin before too i just made the blue scren size too 100vh which didn't changed any no decreased the distances between buttons too

realslimshanky commented 7 years ago

Sure. I would wait for others to review.

sagarchoudhary96 commented 7 years ago

@realslimshanky is anybody looking to these PR's ?

realslimshanky commented 7 years ago

@CuriousLearner @sayanchowdhury would you like to have a look into this?

sagarchoudhary96 commented 7 years ago

@realslimshanky seems like no one looked at it. It would be great if you can see to it and let me know if required what changes to be made ?

sagarchoudhary96 commented 7 years ago

@CuriousLearner I have made the required changes.

sagarchoudhary96 commented 7 years ago

@realslimshanky @CuriousLearner would be great if you can look to it

sagarchoudhary96 commented 7 years ago

@SaptakS removed it. I created it to use it in the index.html but later on i fixed it by making changes in css only. Just forgot to remove it. now it is removed.

sagarchoudhary96 commented 7 years ago

@realslimshanky done👍

sagarchoudhary96 commented 7 years ago

@CuriousLearner it has been too long please see to it