Dockerize Junction - Githubissues

pythonindia / junction

Junction is a software to manage proposals, reviews, schedule, feedback during conference.

MIT License

192 stars 185 forks source link

Dockerize Junction #749

Closed inovizz closed 1 year ago

inovizz commented 1 year ago

Fixes #750

inovizz commented 1 year ago

@inovizz Let's move out the warning fixes in a separate PR just to keep things easier to review.

Yes, will remove the unnecessary code.

inovizz commented 1 year ago

I think we should have .env in gitignore, not adding it to the repo.

We can add a .env.sample to help people in the case.

Sure, will do it. Thanks.

realslimshanky commented 1 year ago

Docker setup works fine for me. Moving forward with functional and code review.

inovizz commented 1 year ago

@inovizz Let's move out the warning fixes in a separate PR just to keep things easier to review.

Looks like I don't have a lot of time to move this to a separate PR now, so we'll go as is. The fixes are any ways similar so shouldn't be a lot of effort to review.

inovizz commented 1 year ago

I've fixed a few things @realslimshanky @ananyo2012 & @Sc0rpi0n101. Can you have a glance once again?

Since I don't have a lot of bandwidth to contribute this week, I propose to merge the current working setup and we can request other volunteers to contribute on pending issues -

gunicorn setup
functional tests
Fix the CI pipeline, we could switch to Github actions or Fix Travis

miphilomath commented 1 year ago

On attempting to login via home page, I am getting the following error.

Though If I login through admin site first, I am logged into the application with no error.

Is anyone else facing similar problem?

ananyo2012 commented 1 year ago

@miphilomath Can we continue conversation in this issue - https://github.com/pythonindia/junction/issues/750 ?