search

pythonindia / junction

Junction is a software to manage proposals, reviews, schedule, feedback during conference.
MIT License
192 stars 185 forks source link

add(#751): add support for github actions #775

Open indiVar0508 opened 1 year ago

ananyo2012 commented 1 year ago

@indiVar0508 This looks good. I have few more task additions.

Also feel free to explore any other tools you seem fit for this and we can discuss here further.

indiVar0508 commented 1 year ago

Hi @ananyo2012 ,

Added coverage step and to report it in PR comment which will be update for each run.

I tried adding testing-report but it seems to be failing ig due to the format which is not acceptable by the test-reporter action, getting error in reading file with jest-junit. ref: https://github.com/indiVar0508/junction/actions/runs/5365317262/jobs/9734065641 . A workaround ig is to use java-junit but requires to unittest-xml-reporting to generate report which still has some limitations ref: https://github.com/dorny/test-reporter/issues/244

ananyo2012 commented 1 year ago

@indiVar0508 Please check https://github.com/marketplace/actions/publish-test-results as an alternative for test-reporting

indiVar0508 commented 1 year ago

Thanks @ananyo2012 , I have added same in this PR you can check once ig some permissions from project is required as i saw last time it failed write comment however it was able to write comment in my forked project. Do let know if anything else is needed to be added or some other issue that i can take up

ananyo2012 commented 1 year ago

@indiVar0508 You need to create a separate workflow for Publishing Results - https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.8.0/README.md#support-fork-repositories-and-dependabot-branches . Let's Name the first Workflow as 'CI' and second one as 'Test Report'.

Also the Pull request comments should only run during Pull request events, not for master branch.

indiVar0508 commented 1 year ago

Added as per comments @ananyo2012