search

pythonindia / pyconindia2012

PyCon India 2012 & 2013 website
http://in.pycon.org/2013/
17 stars 10 forks source link

Change Branding on /funnel #13

Closed anandology closed 11 years ago

anandology commented 12 years ago

Funnel has HasGeek logos now. We should change it to use PyCon India themes.

I've forked funnel as ipss/funnel. I don't think is is possible to customize Funnel except by changing the templates.

@jace let me know if there is any better way.

anandology commented 12 years ago

@jace says that it is possible to customize funnel to use baseframe.

https://github.com/hasgeek/funnel/pull/7#issuecomment-6195359

Anyone interested to take up this task?

dash1291 commented 12 years ago

Can someone give me a few starting hints, if I want to take up this task?

satyaakam commented 12 years ago

@dash1291 have you poked around anything on this one ... afaik look at this sample app https://github.com/hasgeek/hgapp and customize funnel to use baseframe in a similar manner , so once we have that working then we can re brand funnel according to pycon india themes.

abhaga commented 12 years ago

I have sent a pull request on https://github.com/ipss/funnel for integrating it with baseframe. Have a look if it looks alright.

satyaakam commented 12 years ago

@abhaga hi i do not see the pull request ...can you try resending it

anandology commented 12 years ago

The pull request is at https://github.com/ipss/funnel/pulls.

I tried playing with it and found that it still hard to customize it even after adding baseframe support. Also the layout of the top header is out of sync.

I put a quick hack to customize the funnel look and feel. It basically overwrites the templates and images in funnel submodule by running make copy.

https://github.com/ipss/pyconindia2012/commit/d0581fff1ffaa115ee5ddc20f798f50c7773e0b9

It seems to be working fine, even though is a dirty hack that I hate.

http://in.pycon.org/2012/

anandology commented 12 years ago

I know that this is not very good solution, I pushed it because we can now safely work on pushing CFP and work on this at a slow pace.

jace commented 12 years ago

You should fork funnel. I'm going to work on making it modular for Eventframe, our new framework for event websites, but this is a few weeks away.

Let me know if you need help with understanding Baseframe. It's actually very customizable and I've been pushing in patches to make it even more modular.

anandology commented 12 years ago

@abhaga's patch integrates baseframe quite well. Even after doing that, it is not very easy to customize the templates without changing Funnel templates. Ideally I would like to keep all my app specific customizations in a different place and keep Funnel with core updates.

I ended up write a script to copy the custom templates to overwrite the existing ones in the Funnel before starting the app.

jace commented 12 years ago

Let me take a look and get back. Will need a couple of days to get other work out of the way.

anandology commented 12 years ago

On Mon, Jun 18, 2012 at 10:11 PM, Kiran Jonnalagadda reply@reply.github.com wrote:

Let me take a look and get back. Will need a couple of days to get other work out of the way.

Thanks. There is no hurry. We've a work-around in place.