pythonnet / clr-loader

Loader for different .NET runtimes
MIT License
32 stars 23 forks source link

Build issue when using dotnet-sdk v6 #19

Closed m-rossi closed 2 years ago

m-rossi commented 2 years ago

I just tested creating a recipe for conda-forge and seem to get some issues with dotnet-sdk v6:

"System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\Users\USERNAME\miniforge3\conda-bld\clr_loader_1637417796354\_build_env\dotnet\sdk-manifests'

dotnet-sdk v5 seems to work fine. I tried to find out which dotnet-sdk is used in your github-actions, but failed. Which version you use?

If you are using v6 this may be related to the build process in the conda-forge-recipe: https://github.com/conda-forge/dotnet-feedstock

filmor commented 2 years ago

I have only been using v5 so far (that's the version that is available on gentoo). I will test v6 tomorrow.

filmor commented 2 years ago

I can't reproduce this on Linux. Both clr-loader and pythonnet build fine with .NET SDK v6.

/EDIT: I can indeed reproduce this with the conda-forge dotnet package. With a distro-installed .NET SDK, everything works fine, so I'd guess that this is a problem in their packaging.

filmor commented 2 years ago

Since the error happens in dotnet which we call directly just by name, I suggest verifying that indeed the correct binary is picked. It might be worth reporting this to the conda-forge recipe maintainers for dotnet as well.

filmor commented 2 years ago

Okay, last comment on this: I have found the issue and proposed a PR here https://github.com/conda-forge/dotnet-feedstock/pull/45. The "published" version of the .NET 6 SDK from conda-forge is simply broken as it misses a new directory.

m-rossi commented 2 years ago

Okay, last comment on this: I have found the issue and proposed a PR here conda-forge/dotnet-feedstock#45. The "published" version of the .NET 6 SDK from conda-forge is simply broken as it misses a new directory.

Great, thank you! I will try with the new version once your PR is merged.