Add small screen interface, expose auto-scan, color, and Unicode settings

pythops / impala

🛜 TUI for managing wifi on Linux.

GNU General Public License v3.0

741 stars 9 forks source link

Add small screen interface, expose auto-scan, color, and Unicode settings #11

Closed ardangelo closed 2 months ago

ardangelo commented 3 months ago

Planning to add Impala to a Raspberry Pi-based device with a small screen. This PR adds a small-screen mode with a tabbed interface.

Resizing Impala

Also:

Add config file settings for auto-scan, color mode, and Unicode/ASCII.
Fixes high CPU usage. The default 500us poll was hammering DBus and causing lag on Raspberry Pi. The new 50000us poll time does not bog down the system as much.
Fixes terminal not resetting properly on exit.

pythops commented 3 months ago

Also, the linting is broken. Run the following commands for more infos

          cargo clippy --workspace --all-features -- -D warnings
          cargo fmt --all -- --check

ardangelo commented 3 months ago

Thanks for the comments, I've addressed them all.

ardangelo commented 3 months ago

Thanks, fixed the hard-coded dialog widths.

Last commits also change all the hard-coded colors to use a common palette. This makes adding monochrome mode easier. (The Pi device I'm working on has a monochrome display and had some problems with the colors and table highlights).

pythops commented 3 months ago

I noticed couple of things:

the help popup is not centered in normal mode.
in the small mode, when the help popup shows, the background got darker. it should still display what was before the popup. Same for the auth popup btw.

This is becoming really hard to review as there is lot of changes in different modules. Can we break it down into small PRs instead ?

pythops commented 2 months ago

I am gonna close this PR as there is no update about it. feel free to open a new one with smaller scope and changes.