pythops / jetson-image

💾 Create minimalist, Ubuntu based images for the Nvidia jetson boards
349 stars 108 forks source link

Add bzip2 as alternative compression options to CI #95

Closed debloper closed 1 year ago

debloper commented 1 year ago

Please check out: https://github.com/debloper/jetson-nano-image/commit/0cd1dedfcdeaec0a48d2ace300b7344d793b19f1 (corresponding workflow run & release) for reference.

Not sending my initial patch, as I think there's no good reason to remove lrzip (aside from saving a little bit of CI time - which is not a big enough tradeoff - as it gives better compression, for the ones who can use its advantages).

pythops commented 1 year ago

Thanks for the PR but I don't see why adding bzip2 add any value here to be honest. if it's only for this reason

some distros don't have lrzip readily available

then I think it's not convincing enough. lrzip is easily installable so it's not an issue

debloper commented 1 year ago

Basically, the number of users who already has lrzip to readily decompress the distributables when discovering this repo, is a very small number - compared to the people who can readily use bz2. So, for most people it adds extra overhead.

I wish lrzip was more popular (I just became a fan of its compression), but until it gets there, let's give people both the choices?

pythops commented 1 year ago

Have you tried bzip2 and does it compress the final images to a size below 2GB ? what's the final image size ? otherwise they won't be published on github release