search

pythops / tenere

🤖 TUI interface for LLMs written in Rust
https://crates.io/crates/tenere
GNU General Public License v3.0
358 stars 8 forks source link

Model configuration value is not used #17

Closed SeanAtSigma2 closed 9 months ago

SeanAtSigma2 commented 9 months ago

Hello! I was trying to set the model to gpt-4-1106-preview and found that it wasn't picking up the change.

I believe the code shows a hardcoded value to gpt-3.5-turbo: https://github.com/pythops/tenere/blob/5109979d1949e8925cd6cb7528139c7b60e6e932/src/chatgpt.rs#L76

I'd be happy to contribute this change if you like. Or I can update the README to remove this reference of being able to set the model if you don't plan to support this functionality.

Thank you for creating an awesome tool by the way!

pythops commented 9 months ago

Good catch. Thanks for reporting it. The value should be picked up from the config. As you like, you can open a PR or I can fix it this evening.

pythops commented 9 months ago

I've just pushed the fix to master.

SeanAtSigma2 commented 9 months ago

Wow, I'm blown away at how fast you were able to implement that. Thank you so much again for creating such a useful tool! It's becoming a daily driver for me

SeanAtSigma2 commented 9 months ago

For reference later:

This was fixed by: https://github.com/pythops/tenere/commit/b27252c45c6fbb60172f927040a85812d9caa88a

pythops commented 9 months ago

You're welcome :) Glad that you like it