Closed fallen closed 4 years ago
@fallen I plan to try to take a look at this tomorrow! :)
Thanks a lot! :)
If everything is OK then please approve the PR :)
@fallen It seems to me that the translation files are still not good (at least the French translations seem to still be mixed up). I'll let you double check those. Except that it's OK :)
@fallen It seems to me that the translation files are still not good (at least the French translations seem to still be mixed up). I'll let you double check those. Except that it's OK :)
Are you referring to weird entries with "wrong translations" but marked #, fuzzy
?
Those are generated by Django and there is no way to stop it :/
It's "proposed translations", that sometimes are good, but most of the time are wrong.
It seems Django developers don't want to add a flag to disable this: https://code.djangoproject.com/ticket/10852
Anyway, when marked #, fuzzy
, the entries won't be used by the gettext translation system.
Yep, there are the translations I was talking about, I thought you wanted to correct them manually. I don't know how you manage translations for this project, when you add new labels. Currently the new feature is not translated into French, is that acceptable for you?
Yep, there are the translations I was talking about, I thought you wanted to correct them manually. I don't know how you manage translations for this project, when you add new labels. Currently the new feature is not translated into French, is that acceptable for you?
Translations are - since recently - handled via Framasoft's weblate: https://weblate.framasoft.org/projects/pytition/pytitions/ Ah yes, Ok I guess I can indeed at least do the job for French language :)
Yep, there are the translations I was talking about, I thought you wanted to correct them manually. I don't know how you manage translations for this project, when you add new labels. Currently the new feature is not translated into French, is that acceptable for you?
Translations are - since recently - handled via Framasoft's weblate: https://weblate.framasoft.org/projects/pytition/pytitions/ Ah yes, Ok I guess I can indeed at least do the job for French language :)
Should be OK now o/
Hmm, I don't know why but the new labels are still not used for me
Hmm, I don't know why but the new labels are still not used for me
That's because I didn't generate the .mo files. There seem to be no consensus on whether those should be under git or not. Or whether they should be compiled by the one who installs the app. Have you tried doing "python3 pytition/manage.py compilemessages"?
Ok, fair enough! :) LGTM
Thanks a lot for the review!
@fallen I plan to try to take a look at this tomorrow! :)