Disable User petition with setting

pytition / Pytition

Django app for self-hosted privacy-friendly online petitions

https://pytition.org

BSD 3-Clause "New" or "Revised" License

99 stars 28 forks source link

Disable User petition with setting #237

Closed martinlehoux closed 4 years ago

martinlehoux commented 4 years ago

Closes #227
Introduce new DISABLE_USER_PETITION setting
Redirect to dashboard users trying to create a user petition with a warning
Users still can use org petitions
Also some linting on the base settings

TODO :

[x] Document new setting

martinlehoux commented 4 years ago

there seem to be an unrelated error in the CI : PermissionError: [Errno 13] Permission denied: '/var/lib/jenkins/workspace/Pytition_PR-237/pytition/mediaroot/julia/logo.png'

fallen commented 4 years ago

About the CI issue,maybe try to rebase your branch on updated master (fix the conflict it will produce in settings.py) and force push your branch?

martinlehoux commented 4 years ago

About the doc, I can add it to the config file with description and here https://pytition.readthedocs.io/en/latest/configuration.html ? Is that it ?

fallen commented 4 years ago

About the doc, I can add it to the config file with description and here https://pytition.readthedocs.io/en/latest/configuration.html ? Is that it ?

Yes, in settings.py and in doc/configuration.rst

fallen commented 4 years ago

I don't understand why the CI is still red, but I guess that's not important, as long as when merged in master CI is green which I guess it will be!

fallen commented 4 years ago

I've just been thinking about something: we should also forbid users to transfer petitions to organizations while the DISABLE_USER_PETITION setting is set. So that a previously created petition could not be transferred to circumvent the blocking.

That would be somewhere in there: https://github.com/pytition/Pytition/blob/master/pytition/petition/views.py#L1613

martinlehoux commented 4 years ago

Will work on that tonight