Add pagination for petitions (#240)

[pnu-s]

Fixes #240

Notes:

• I added a simple pagination, without "first" and "last" buttons, this could be added later on
• I made it a way to avoid making changes which require new translations, but that's up to you
• I made the choice to add the pagination code into generic_petition_list.html rather than index.html, but it could work on either

[pnu-s]

@fallen Damn, I totally forgot to check whether the template generic_petition_list.html was used for other views... Not sure neither how petitions.has_other_pages doesn't crash but it seems this case is handled by Django.

I'm not sure what is the best option here:

1. Move the pagination HTML to index.html
2. Add the paginator everywhere

I'd go with option 1 personally, as I'm not sure pagination makes sense everywhere (for instance for the all_petition option).

WDYT?

[fallen]

I'm not sure what is the best option here:

1. Move the pagination HTML to index.html

2. Add the paginator everywhere

I'd go with option 1 personally, as I'm not sure pagination makes sense everywhere (for instance for the all_petition option).

WDYT?

I kind of think using Paginator makes sense everywhere, except - I would say - in the dashboards. What do you think @martinlehoux ?

[pnu-s]

@fallen Then I guess it doesn't make sense to keep the whole all_petitions.html template, as it is essentially the same as index.html now with pagination.

I can make the changes. I'll add it anyway on org and user profile, it will only show if there are more than 12 petitions, otherwise it'll be the same as now

[fallen]

@fallen Then I guess it doesn't make sense to keep the whole all_petitions.html template, as it is essentially the same as index.html now with pagination.

I can make the changes. I'll add it anyway on org and user profile, it will only show if there are more than 12 petitions, otherwise it'll be the same as now

Sure, you're right, I think we can get rid of all_petitions.html. Nice catch!

[pnu-s]

Just made the changes as discussed.

• Use a setting to define the number of elements per page
• Update the tests to reflect the changes
• Keep a redirection from /all_petitions to make sure it doesn't break existing links
• I didn't add pagination for the search as it requires to add more complexity (to handle query parameters). I've already done it on another project, so I can do it if needed, but it requires to create a custom templatetag
• Note that my IDE removes trailing whitespaces, so don't be surprised. I can revert if needed