pytition / Pytition

Django app for self-hosted privacy-friendly online petitions
https://pytition.org
BSD 3-Clause "New" or "Revised" License
100 stars 28 forks source link

"Re-send confirmation e-mail to all unconfirmed" resends the email to ALL signatories #280

Closed Xebax closed 3 years ago

Xebax commented 3 years ago

Describe the bug When I use the "Re-send confirmation e-mail to all unconfirmed" button, the confirmation email is sent to ALL the signatories, no only to the ones who have not confirmed their signature.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://mydomain/petition/petition_id/show_signatures
  2. Click on "Re-send confirmation e-mail to all unconfirmed"

Expected behavior The confirmation email should be sent only to the signatories that have not confirmed their signature yet but it is sent to all the signatories.

fallen commented 3 years ago

Wow, thanks for the report, it's amazing that this went unnoticed for so long!