Closed fallen closed 4 months ago
Hi @fallen, how are you?
Can I work on this issue?
Hi @rsk2 ! I'm fine thanks! Yes you can, thanks a lot!
@fallen in order to implement this, we will need 7 boolean
fields in the petition
model (one for the email sharing button and remaining 6 for the social network sharing buttons). Each field will indicate whether a particular sharing button needs to be shown or not. Please let me know if you need any changes in this approach.
@fallen in order to implement this, we will need 7
boolean
fields in thepetition
model (one for the email sharing button and remaining 6 for the social network sharing buttons). Each field will indicate whether a particular sharing button needs to be shown or not. Please let me know if you need any changes in this approach.
I think this is fine, also I think we should pay attention to the migrations and maybe do it by steps:
has_share_buttons
property was Truehas_share_buttons
property@fallen should I add make these field changes for the PetitionTemplate
model as well?
@fallen should I add make these field changes for the
PetitionTemplate
model as well?
Ah yes, good idea. Indeed I can imagine someone could want to set in his/her template that some buttons are enabled.
For now it's either all buttons or none. Allow to chose which are wanted per-petition.