search

pytoolz / toolz

A functional standard library for Python.
http://toolz.readthedocs.org/
Other
4.7k stars 263 forks source link

Deprecate/remove `toolz.sandbox` #362

Open eriknw opened 7 years ago

eriknw commented 7 years ago

I'd like to remove toolz.sandbox. Any objections? Should we deprecate it first?

I think toolz is a very mature and more-or-less finished package and would like to aim for a 1.0.0 release soon. toolz.sandbox doesn't seem like something that fits. To the best of my knowledge, nobody uses toolz.sandbox.

llllllllll commented 7 years ago

We have used it in a few places (https://github.com/quantopian/zipline/blob/master/zipline/utils/memoize.py#L10); I think we have only ever used unzip. Maybe move unzip into toolz?

eriknw commented 7 years ago

Thanks for the feedback. We can move unzip to itertoolz. Sounds like we should also go through a deprecation cycle and link to this issue for feedback.

eriknw commented 7 years ago

I suppose there is no rush to remove sandbox and little harm in keeping it around indefinitely as a deprecated module. I would like to deprecate it though and remove it from the docs.