search

pytoolz / toolz

A functional standard library for Python.
http://toolz.readthedocs.org/
Other
4.66k stars 259 forks source link

replace blacklist/whitelist with exclude/include or denylist/allowlist #508

Closed domoritz closed 2 years ago

domoritz commented 3 years ago

The old terminology is being dropped across tools and languages so it would be nice to update this library as well.

ruancomelli commented 3 years ago

I strongly agree with this.

Since this would be a breaking change (pick(whitelist=...) wouldn't work anymore), it should be implemented before v1.0.0 comes out.

@domoritz have you seen other instances (aside from blacklist/whitelist) that should be replaced? @eriknw what do you think?

domoritz commented 3 years ago

In the meantime, you could support both and update the docs to use the new terminology. I have not looked through the whole codebase. Google has a list of words to avoid at https://developers.google.com/style/word-list and guidelines for writing inclusive docs at https://developers.google.com/style/inclusive-documentation.

eriknw commented 2 years ago

I agree too. Thanks for brining this to our attention. blacklist/whitelist has been changed (and sorry it took so long to do so). I'll look more closely at those documents when I have a chance.

Please let us know if anything else should be changed.