search

pytorch-ignite / code-generator

Web Application to generate your training scripts with PyTorch Ignite
https://code-generator.pytorch-ignite.ai/
BSD 3-Clause "New" or "Revised" License
40 stars 23 forks source link

Fix for "open in colab" opens the same zip after updates #295

Closed theory-in-progress closed 1 year ago

theory-in-progress commented 1 year ago

Description

Fix #291

What is the purpose of this pull request?

netlify[bot] commented 1 year ago

Deploy Preview for code-generator ready!

Name Link
Latest commit e0609539447f949e5ad78f3f90f98f1eccc34e98
Latest deploy log https://app.netlify.com/sites/code-generator/deploys/64e2298053ef6f00087117a1
Deploy Preview https://deploy-preview-295--code-generator.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vfdev-5 commented 1 year ago

Have you tested on the deployed PR app if it works ?

theory-in-progress commented 1 year ago

Yes, it works for the open in colab button :+1: Am testing the generate link button now...

vfdev-5 commented 1 year ago

For permanent code link (for wget) it should work the same way ?

Let's refactor the common code and try to add tests for the nbUid if possible

theory-in-progress commented 1 year ago

Yes, was refactoring the code. For now the problem of opening in colab is fixed. I will send a new PR for refactored code and tests.