pytorch-ignite / code-generator

Web Application to generate your training scripts with PyTorch Ignite
https://code-generator.pytorch-ignite.ai/
BSD 3-Clause "New" or "Revised" License
40 stars 23 forks source link

Add commit hash to the getZipUid function for PR Builds #319

Closed guptaaryan16 closed 1 year ago

guptaaryan16 commented 1 year ago

Description

This PR aims to improve the current behaviour of the CI for both the PR and deployment . As of now, we have a functionality where we try to create uuid for each configuration of the code generator app template and then return this using a getZIPUid function. This created a problem of not able to differentiate between the zip files and notebooks pushed for the PR Builds and the Deployment Builds.

We introduced a new netlify variable PR_BUILD which is false only when it is a production build. When the PR_BUILD=true, we are going to add the commit hash to the commit uuid generated by the getZipUid function.

Additional context

This issue was suggested in #317


What is the purpose of this pull request?

netlify[bot] commented 1 year ago

Deploy Preview for code-generator ready!

Name Link
Latest commit 3694b263bf9ee405a80a840557648eac2002e38d
Latest deploy log https://app.netlify.com/sites/code-generator/deploys/6509574af953df0008a05da9
Deploy Preview https://deploy-preview-319--code-generator.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.