pytorch-ignite / examples

Examples, tutorials, and how-to guides
BSD 3-Clause "New" or "Revised" License
10 stars 11 forks source link

Custom Metrics Example #46

Open Ishan-Kumar2 opened 2 years ago

Ishan-Kumar2 commented 2 years ago

A tutorial which shows how custom metrics can be made using Metric class would be useful. The example can create an easy metric like the Levenshtein Distance between two strings. Reference - https://pytorch.org/ignite/metrics.html#how-to-create-a-custom-metric

Priyansi commented 2 years ago

Thank you for this great suggestion @Ishan-Kumar2 ! I agree this would be really helpful. If we are going to implement just one metric, perhaps, this would better be suited as a how-to guide. If we are talking about implementing more than one custom metric, we can label this as a tutorial. Would you like to work on this issue?

Ishan-Kumar2 commented 2 years ago

Having it as a how-to-guide sounds good. I am happy to implement it once I am done with the NMT example. Till we can tag it as a help-wanted for new contributors, what do you say?

Priyansi commented 2 years ago

Yes sounds good! I'll also attach the hacktoberfest label.

mdrpanwar commented 2 years ago

@Priyansi Could you please assign this to me? I would like to work on this how-to guide.

Priyansi commented 2 years ago

Yeah sure, that'd be great! Feel free to ask any questions either here on Discord (for faster replies).

vfdev-5 commented 2 years ago

@mdrpanwar any updates on this issue ?

mdrpanwar commented 2 years ago

@vfdev-5 I am working on it and it's mostly complete. I will raise the PR today.

vfdev-5 commented 2 years ago

Sounds great, thanks a lot !

Priyansi commented 2 years ago

Hey @mdrpanwar , are you facing any issues with this? Any updates?

vfdev-5 commented 2 years ago

@mdrpanwar could you please submit your draft PR such that we could finish it from our side. Thanks !