search

pytorch-ignite / examples

Examples, tutorials, and how-to guides
BSD 3-Clause "New" or "Revised" License
11 stars 11 forks source link

updated generate.py to work with existing notebooks #59

Closed Ishan-Kumar2 closed 2 years ago

Ishan-Kumar2 commented 2 years ago

In ref to this comment, added support for appending frontmatter to existing notebooks.

ydcjeff commented 2 years ago

@Ishan-Kumar2

Can you add some info in the README that this script also updates the existing notebooks with required frontmatters?

Ishan-Kumar2 commented 2 years ago

@ydcjeff If you run the generate.py more than once on a notebook it will add the front matter cell again. Should we tackle this some way or is it fine?

vfdev-5 commented 2 years ago

@ydcjeff If you run the generate.py more than once on a notebook it will add the front matter cell again. Should we tackle this some way or is it fine?

Yes, please, make it exit saying that nothing to do in this case

Ishan-Kumar2 commented 2 years ago

@vfdev-5 I have added that check, please have a look now.