search

pytorch-ignite / examples

Examples, tutorials, and how-to guides
BSD 3-Clause "New" or "Revised" License
11 stars 11 forks source link

Removed DiskHandler wrapper in Checkpoint calls #72

Closed anirudhb11 closed 2 years ago

anirudhb11 commented 2 years ago

The following PR addresses #53 by replacing all instances of save_handler = DiskHandler()

anirudhb11 commented 2 years ago

@Priyansi the diff is huge even though changes are minimum -- making changes to one of the files (02-convert-pytorch-to-ignite) automatically introduced some new changes -- perhaps indentation introduced via the IDE?

Priyansi commented 2 years ago

Hey @anirudhb11 thanks for the PR! Could you also removes instances of DiskSaver being imported in different files for example here, DiskSaver could remain unused. Thanks!

anirudhb11 commented 2 years ago

Hey @anirudhb11 thanks for the PR! Could you also removes instances of DiskSaver being imported in different files for example here, DiskSaver could remain unused. Thanks!

@Priyansi I have addressed this.