search

pytorch-labs / attention-gym

Helpful tools and examples for working with flex-attention
BSD 3-Clause "New" or "Revised" License
484 stars 24 forks source link

Typo in README example #55

Closed francois-rozet closed 1 month ago

francois-rozet commented 1 month ago

mask_mod is not defined in the README example. I assume that L53 should be mask_mod = generate_sliding_window(...).

https://github.com/pytorch-labs/attention-gym/blob/f7c93ded4abf9fd8d7dc9d8bcbf57e420b891e2d/README.md?plain=1#L53-L55

drisspg commented 1 month ago

ahh thank you!

drisspg commented 1 month ago

Fixed https://github.com/pytorch-labs/attention-gym/pull/64