Closed drisspg closed 3 months ago
Thanks @drisspg! For all the configuration options my expectations is you should follow the template set by Jerry as in get things working with the quantize()
API and if that doesn't work you 2 should talk more - my comments apply to everything below the Design Details section
@msaroufim Great feedback, thank you!
For the quantize_()
API question: The main difference, from my understanding, is that you have a tensor subclass per strategy: https://github.com/pytorch/ao/blob/05038a1f613b7a1f6b0aec84252021e2be98adff/torchao/quantization/quant_api.py#L282C1-L285C72. Here, we are using one tensor subclass and defining extra module state and forward logic to do this. I think that if in the future we want to support the "full subclass" API, there are a few options:
Weight only
, Dynamic
, Static-Activation
with some interface that all subclasses API, similar to the quantize/dequantize API. I prefer option 3, but I think in the meantime it's okay for this solution to be distinct.
Okay, back to the comments 😉
a) Regarding lack of familiarity, this was more stemming from a comment from @vkuzo saying that in general it's harder to interpret what an nn.module is doing under the hood when it uses subclasses. I agree with this and was more remarking that this may put off more advanced users who want to fully understand all the details.
b) Yup, the export comment was about the Unwrap Subclass annoyance. I spoke with @tugsbayasgalan about this, and they have plans to encode this logic into the export flow, making it no longer a responsibility of the export caller.
In particular, the next two we want to support are the GroupWise and BlockWise. GroupWise FP8 is essentially the MxFP8 format, with the only difference being that the scale is e8 type for mx as opposed to float32 here.
You should be able to run the weight-only code on non-H100 fine; however, attempting to run the FP8 compute paths will error with an 'unsupported device' message.
That was confusing; I meant more of a FlashAttention-like algorithm as opposed to an unfused variant where it's easier to inject FP8 scaling and unscaling around the softmax.
Agreed 😊
This is great!
On a high level, I'd also be interested to hear about how this would compose with distributed, and on the motivation to use a module (vs a subclass, or both a module and a subclass) as the user visible object.
A couple of technical comments:
def quantize_to_float8(
There are also use cases for a two stage API, where first the user calibrates with sample data (for example, for activation scales) and then runs inference using the calibration data. Might be good to align with how torchao is planning to organize this. I noticed the RFC defers this until later, but the code does mention supporting static scales for activations.
quant_config: QuantConfig,
Eventually the quantization settings should be configurable per-module instead of being per-model, it's pretty common to change the settings based on FQN, weight shape, etc.
forward_config: ScaledMMConfig,
scaling_granularity: Optional[ScalingGranularity],
One could argue that these could live inside QuantConfig
Thanks for the detailed note, my main question is for float8 inference, can float8 tensor subclass be expressed as a primitive dtype like (torch.float8_e4m3) + AffineQuantizedTensor (since scale and granularity logic are already implemented there)
@jerryzh168 I think yes, it if you have no ZeroPoint for AQT (or at least if you dont do any actual addition when the zero point is zero since native addition is not supported for float8_e4m3) . However, I do think that the constraints of the scaled_mm kernel would leak pretty heavily into AQT if we tried to merge all into one.
@drisspg zero_point
could be optional I think (https://github.com/pytorch/ao/blob/05038a1f613b7a1f6b0aec84252021e2be98adff/torchao/quantization/quant_primitives.py#L146). what do you mean by constraints of scaled_mm kernel leaking into AQT? AQT also supports dispatching to different kernels based on different conditions
I'm also interested in FP8 matmul inference. A question. I see that triton matmul kernel can work with FP8, and torch.compile can also generate FP8 triton matmul. What is the performance difference between _scaled_mm()
(which is backed by CuDNN or cutlass I assume) and triton FP8 matmul?
I can see that the benefits of using triton FP8 matmul would be allowing more flexible scaling, especially for non-H100. Using existing AQT facilities in torchao, the addition of FP8 inference (using torch.mm + torch.compile -> triton) wouldn't be too challenging.
discussion moved to https://github.com/pytorch/ao/issues/574
RFC: Float8 Inference
Objective
We want to provide an easy mechanism to utilize FP8 in inference, and see both decreased memory usage and performance gains on hardware that supports native FP8 computation. We would like the API to require minimal model rewrites. We also want it to be configurable in such a way as to provide multiple levels of scaling granularity with their own accuracy/performance trade-offs. The solution should be composable with other inference components in the PyTorch ecosystem:
This solution is targeting server-side GPU inference. It is not currently focused on supporting edge or CPU inference.
Background
Float8 inference can be used to reduce memory usage and improve computational efficiency. By using FP8 instead of higher precision formats, we can achieve significant speedups and memory savings with minimal loss in accuracy. The memory saving is unique to float8 inference as opposed to float8 training. For inference, the weights are static and thus do not need the higher precision during weight updates.
Proposal
Float8InferenceLinear Module
We propose a new
Float8InferenceLinear
module that extendsnn.Linear
with Float8 quantization capabilities:This module handles the quantization of weights and activations based on the provided configuration. This module was landed in this PR: #287. It is designed to replace a pre-trained nn.Linear module in an existing model and statically convert the weight to FP8. By default, we do this in E4M3 format.
It provides configuration options via the
QuantConfig
class to encapsulate various quantization settings:The main configuration options are captured in the
ActivationCasting
enum:_scaled_mm
.Top-level API
We propose a top-level API for quantizing models:
This function allows users to easily convert their models to use Float8 inference.
An example of how this can be used on a Hugging Face model can be found in this PR in TorchAO
Proposed Extensions
Scaling Granularity
Currently, we only support TensorWise scaling. Concretely, this is done by calculating the
max(abs(Tensor))
and utilizing this value to compute the Float8Tensor scale. However, due to outlier values in activations, this can have large quantization error. As well, calculating a global reduction across the entire activation tensor can be relatively slow.Therefore, we want to add the option to specify different types of scaling granularities.
The
scaling_granularity
parameter determines how scales are computed:TensorWise
: A single scale is computed for the entire tensor.AxisWise
: Scales are computed along a specified axis of the tensor.We recently added Axiswise scaling support to
_scaled_mm
in this PyTorch PR: #128989. As well, I have a worked PR stack showing how Axiswise scaling can be implemented in Float8Experimental: https://github.com/pytorch-labs/float8_experimental/pull/305We would like to continue generalizing the scaling granularity to:
GroupWise
: Similar to AxisWise but instead of one scale per axis, we have multipleBlockWise
: All other forms can be seen as special cases of this. Scale per 2D tile of activation and weight.Design Details
Tensor Subclass Usage
The implementation utilizes Float8Tensors to encapsulate the scaling as well as dispatch to
_scaled_mm
instead oftorch.mm
. This is not the only way this could be implemented. Since we do not have the autograd constraint that backpropagating grads must match the dtype of the tensor in the forward, we are free to desugar the Float8Tensor into its constituents, store them on the module, and use them in the forward. However, using the tensor subclass, allows us to re-use similar components between training and inference, but it does have downsides:Performance
Compile
As with the rest of this project, we heavily rely on the compile stack to generate efficient and fused casting code. We do actually see some performance gains on heavily compute-bound models, but in general, we require torch.compile for competitive performance.
Export
Currently, it is not possible to run torch.export + AOTI with the publicly available export APIs. However, this PR: https://github.com/pytorch-labs/float8_experimental/pull/295 demonstrates that it is possible. There are plans this half for the export team to make export of nn.modules with subclasses as weights available in the public API.
Limitations and Future Work
Extend ScalingGranularity
bfloat16
._scaled_mm
only supports TensorWise and AxisWise scaling; work is needed to extend to other granularities.Composition with other dtypes/techniques
AffineQuantized
,NF4Tensor
,int4_weight_only
, etc. It is possible that users will want to compose different types within the same model. Work is needed here to ensure that the top-level UX is expressive enough to handle these cases.Standardize on TorchAO APIs
Non-H100 GPU Support
_scaled_mm
's TensorWise support is enabled on sm89, and MI300x + GPUs. However, the AxisWise kernel is based on Cutlass and is not currently supported on any GPU besides H100.Dynamic Shapes
Other Module Support
-While Linear weights take up the majority of model size and compute, other operations can still be amenable to the compute gains from FP8
Examples
Open Questions
_scaled_mm
kernel can support this use case. Is that a problem?Conclusion
This RFC proposes significant enhancements to Float8 inference in PyTorch, aiming to provide a more flexible, efficient, and user-friendly framework for quantization. By supporting various scaling granularities and quantization strategies, we can cater to a wide range of use cases and potentially unlock substantial performance improvements for many models.
Additional Details
Utilizing this script: https://gist.github.com/drisspg/d7ae2134fbb6ca369c4817853c3352fa