search

pytorch-labs / gpt-fast

Simple and efficient pytorch-native transformer text generation in <1000 LOC of python.
BSD 3-Clause "New" or "Revised" License
5.35k stars 484 forks source link

Fixing synchronization issue when non-zero GPU is used as a device #113

Closed Artyom17 closed 4 months ago

Artyom17 commented 4 months ago

If --device='cuda:1' (or any other non-zero cuda device) is used for generate.py then device_sync(device) is not working correctly, since torch.cuda.synchronize() is called w/o params and torch.cuda.current_device() is still 'cuda:0'. Thus, adding the 'device' as a parameter for torch.cuda.synchronize() call.

facebook-github-bot commented 4 months ago

Hi @Artyom17!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Chillee commented 4 months ago

Thanks!

Artyom17 commented 4 months ago

I've signed the CLA, just FYI

facebook-github-bot commented 4 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!