search

pytorch-labs / gpt-fast

Simple and efficient pytorch-native transformer text generation in <1000 LOC of python.
BSD 3-Clause "New" or "Revised" License
5.34k stars 484 forks source link

Fix rope base issue with llama 3 #181

Closed VikParuchuri closed 2 weeks ago

VikParuchuri commented 2 weeks ago

Llama 3 has a non-standard rope base, but the huggingface config value is different from the name gpt-fast expects. This causes issues, namely #179 .

From my testing, manually setting the rope base seems to fix the problem.

facebook-github-bot commented 2 weeks ago

Hi @VikParuchuri!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 2 weeks ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

yanboliang commented 2 weeks ago

Thanks @VikParuchuri for fixing this!