search

pytorch-labs / torchfix

TorchFix - a linter for PyTorch-using code with autofix support
Other
98 stars 16 forks source link

Refactored each import item from node using libcst.matchers.matches #37

Closed Francescaaa closed 7 months ago

Francescaaa commented 7 months ago

Modified code still performs the same checks for outdated import statement "import torchvision.models as models" using libcst.matchers.matches as suggested by ticket T182198161. IsInstance checks are removed because m.ImportAlias() already ensured the right instance is used.

facebook-github-bot commented 7 months ago

Hi @Francescaaa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 7 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

kit1980 commented 7 months ago

Please run black formatter on the modified file to make the linter happy.