pytorch / ELF

ELF: a platform for game research with AlphaGoZero/AlphaZero reimplementation
Other
3.37k stars 567 forks source link

GoGoD commentary SGFs with an illegal move #157

Open y-ich opened 5 years ago

y-ich commented 5 years ago

Hi.

Since I found illegal moves in gogod_commentary SGFs, I wrote a script to check files. Here is result.

SGFs with an illegal move in main line.

gogod_commentary/1800-49/1802-01-22a.sgf gogod_commentary/1930-39/1930-06-21b.sgf gogod_commentary/1930-39/1933-09-14a.sgf gogod_commentary/1970-75/1971-03-24a.sgf gogod_commentary/1992/1992-06-11a.sgf gogod_commentary/1994/1994-06-30f.sgf gogod_commentary/1995/1995-03-12g.sgf gogod_commentary/1995/1995-06-08j.sgf gogod_commentary/1996/1996-07-31b.sgf gogod_commentary/1997/1997-03-18o.sgf gogod_commentary/1998/1998-05-11b.sgf gogod_commentary/2001/2001-04-05aa.sgf gogod_commentary/2001/2001-04-23a.sgf gogod_commentary/2001/2001-05-10aa.sgf gogod_commentary/2002/2002-04-25q.sgf gogod_commentary/2003/2003-06-20b.sgf gogod_commentary/2014/2014-04-18e.sgf gogod_commentary/2014/2014-12-13z.sgf

SGFs with an illegal move in a variation.

gogod_commentary/1960-69/1963-07-04b.sgf gogod_commentary/1970-75/1974-10-30b.sgf gogod_commentary/1985/1985-05-28b.sgf gogod_commentary/1989/1989-01-28a.sgf gogod_commentary/1992/1992-07-04h.sgf gogod_commentary/1993/1993-09-02a.sgf gogod_commentary/1994/1994-07-14g.sgf gogod_commentary/1995/1995-04-26d.sgf gogod_commentary/1997/1997-03-06e.sgf gogod_commentary/1998/1998-10-14a.sgf gogod_commentary/2000/2000-04-06b.sgf gogod_commentary/2002/2002-03-15b.sgf gogod_commentary/2003/2003-09-28c.sgf gogod_commentary/2004/2004-03-27b.sgf gogod_commentary/2004/2004-05-10f.sgf gogod_commentary/2005/2005-09-11b.sgf gogod_commentary/2006/2006-04-17s.sgf gogod_commentary/2006/2006-05-01i.sgf gogod_commentary/2007/2007-06-28q.sgf gogod_commentary/2009/2009-09-14b.sgf gogod_commentary/2009/2009-11-23c.sgf gogod_commentary/2010/2010-11-23j.sgf gogod_commentary/2011/2011-09-06k.sgf gogod_commentary/2013/2013-06-29h.sgf gogod_commentary/2013/2013-06-29i.sgf gogod_commentary/2013/2013-08-18h.sgf gogod_commentary/2013/2013-08-26c.sgf gogod_commentary/2013/2013-11-02g.sgf gogod_commentary/2013/2013-11-07l.sgf gogod_commentary/2015/2015-04-09l.sgf gogod_commentary/2016/2016-10-03c.sgf gogod_commentary/2017/2017-03-07h.sgf gogod_commentary/2017/2017-06-30j.sgf gogod_commentary/2018/2018-02-00a.sgf

Illegal moves in main line look like forgetting ko thread.

I have no idea about illegal moves in ELF OpenGo variations. I hope that you will check these.

And ELF OpenGo seems not to treat called-off games such as three-ko and chosei properly. These also affect hawkeye analyses of the SGF.

Thank you so much for your huge contribution to Go.