pytorch / FBGEMM

FB (Facebook) + GEMM (General Matrix-Matrix Multiplication) - https://code.fb.com/ml-applications/fbgemm/
Other
1.17k stars 474 forks source link

Remove importing GlobalWeightDecayDefinition in split_table_batched_embeddings_ops #2904

Closed spcyppt closed 1 month ago

spcyppt commented 1 month ago

Summary: f585120721 packaged split_table_batched_embeddings_ops.py but not split_table_batched_embeddings_ops_training.py. Thus it fails to import GlobalWeightDecayDefinition from an older version of split_table_batched_embeddings_ops_training.py.

Reviewed By: spcyppt

Differential Revision: D60271207

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D60271207

netlify[bot] commented 1 month ago

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
Latest commit 0397b28487c1ea86addfbdf9ed91687a52d12a15
Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/66a30d96e85eb400083e7125
Deploy Preview https://deploy-preview-2904--pytorch-fbgemm-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

facebook-github-bot commented 1 month ago

This pull request has been merged in pytorch/FBGEMM@280897791fb8b23db106ba4026a9b0fa75b90224.