pytorch / FBGEMM

FB (Facebook) + GEMM (General Matrix-Matrix Multiplication) - https://code.fb.com/ml-applications/fbgemm/
Other
1.17k stars 474 forks source link

Add rounding mode options to mx_github #2933

Closed summerdengfb closed 1 month ago

summerdengfb commented 1 month ago

Summary: We found the rounding mode when selecting the block scales in MX formats is critical to numeric accuracies. Josh has added rounding mode options in the fp32 to mx4 conversion kernels in D59562029. Here is to add the options to mx_github library which supports more mx formats. To use different options from the default 'floor' method in the cuda kernel, need to specify custom_cuda=False in the mx specs.

Differential Revision: D60682029

netlify[bot] commented 1 month ago

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
Latest commit 8eebf64761e97a85fa94ea82dbd4e6b5e848e86f
Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/66ad60c1660d400008d93574
Deploy Preview https://deploy-preview-2933--pytorch-fbgemm-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D60682029

facebook-github-bot commented 1 month ago

This pull request has been merged in pytorch/FBGEMM@b0c16d7d7612308f325358bf10fe34214668a3e9.