search

pytorch / FBGEMM

FB (Facebook) + GEMM (General Matrix-Matrix Multiplication) - https://code.fb.com/ml-applications/fbgemm/
Other
1.17k stars 474 forks source link

Do not import from pyre_extensions #2937

Closed sarckk closed 1 month ago

sarckk commented 1 month ago

Summary: pyre_extensions not availabe in trec OSS.

breaks torchrec build tests: https://github.com/pytorch/torchrec/actions/runs/10222011214/job/28285796153

pyre_extensions is also not safe to use in code that will be torch.packaged, as it requires sys for version checks

Reviewed By: duduyi2013

Differential Revision: D60792133

netlify[bot] commented 1 month ago

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
Latest commit 3420b6433df571530112ab7f78f7e7a912cb6ca6
Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/66b14dc97c807f00084dd052
Deploy Preview https://deploy-preview-2937--pytorch-fbgemm-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D60792133

facebook-github-bot commented 1 month ago

This pull request has been merged in pytorch/FBGEMM@7e17a6e96f4bc3e83cbae02cc195a1c2ef12681b.