pytorch / FBGEMM

FB (Facebook) + GEMM (General Matrix-Matrix Multiplication) - https://code.fb.com/ml-applications/fbgemm/
Other
1.17k stars 474 forks source link

Work around offsets and indices type mismatch int TBE training #3037

Closed sryap closed 2 weeks ago

sryap commented 2 weeks ago

Summary: D61524189 added bounds_check_indices in the prefetch function. It expects indices and offsets to have the same type. However, that is not always the case. This diff forces type casting on indices and offsets if they do not have the same type. A long term solution is to update bounds_check_indices to support indices and offsets that have different types.

Reviewed By: PaulZhang12

Differential Revision: D61801695

netlify[bot] commented 2 weeks ago

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
Latest commit 324888f87782cc95978af590844076878cc1b077
Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/66ccb53791075b00089a32cb
Deploy Preview https://deploy-preview-3037--pytorch-fbgemm-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D61801695

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D61801695

facebook-github-bot commented 2 weeks ago

This pull request has been merged in pytorch/FBGEMM@e782781db9f6d136e2b7b178221c33a54409ba0f.