The ffmpeg integration shouldn't download linux binaries when the UNIX cmake variable is defined - it should issue proper messages for non-Linux UNIX systems

pytorch / audio

Data manipulation and transformation for audio signal processing, powered by PyTorch

https://pytorch.org/audio

BSD 2-Clause "Simplified" License

2.43k stars 636 forks source link

The ffmpeg integration shouldn't download linux binaries when the UNIX cmake variable is defined - it should issue proper messages for non-Linux UNIX systems #3716

Open yurivict opened 6 months ago

yurivict commented 6 months ago

🐛 Describe the bug

The cmake code assumes here that UNIX implies linux, which isn't correct.

The code should check whether OS is Linux and only download linux binaries in that case. It should issue the relevant error message for other OSes.

*BSD systems are in the UNIX category but aren't able to run linux binaries.

Versions

2.x.

mthrok commented 6 months ago

Hi - Thanks for the report. I admit that I am mistakenly confusing these. Would you be able to provide a fix?

yurivict commented 6 months ago

Would you be able to provide a fix?

Sorry, I am only a port maintainer and don't have resources to provide a fix.

mthrok commented 6 months ago

Would you be able to provide a fix?

Sorry, I am only a port maintainer and don't have resources to provide a fix.

okay. I left the project and there aren't people following up. If this is causing some issue on some BSD ecosystem, let me know, I will try to find a time to fix.