pytorch / audio

Data manipulation and transformation for audio signal processing, powered by PyTorch
https://pytorch.org/audio
BSD 2-Clause "Simplified" License
2.43k stars 636 forks source link

Doc: references for `lfilter` implementation #3734

Closed yoyololicon closed 5 months ago

yoyololicon commented 5 months ago

Add references to @yoyololicon and @forgi86's works for the core implementation of lfilter. @forgi86 implemented the same logic as torchaudio's in forgi86/dynonet for efficient backpropagation.

pytorch-bot[bot] commented 5 months ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3734

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (2 Unrelated Failures)

As of commit 7be5a28304216915d20f5e2a50b058685d0dfcee with merge base b2d9c3e315405f2b5cfdfa5b93f849d5b27a4109 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

* [Unittests on Windows CPU / unittests-windows-cpu / windows-job](https://hud.pytorch.org/pr/pytorch/audio/3734#20876911441) ([gh](https://github.com/pytorch/audio/actions/runs/7660179913/job/20876911441)) `ImportError: DLL load failed while importing _C: The specified module could not be found.` * [Unittests on Windows GPU / unittests-windows-gpu / windows-job](https://hud.pytorch.org/pr/pytorch/audio/3734#20876911434) ([gh](https://github.com/pytorch/audio/actions/runs/7660179912/job/20876911434)) `ImportError: DLL load failed while importing _C: The specified module could not be found.`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mthrok commented 5 months ago

Feel free to merge!