search

pytorch / audio

Data manipulation and transformation for audio signal processing, powered by PyTorch
https://pytorch.org/audio
BSD 2-Clause "Simplified" License
2.43k stars 636 forks source link

Bug in error message in forced alignment #3747

Closed zmolikova closed 4 months ago

zmolikova commented 4 months ago

I believe that in the error message below, the variables T and L are switched (not in the condition of the check itself, but in the message).

https://github.com/pytorch/audio/blob/5286f9f60d8647fb4a490cdf22eac39a54e63a80/src/libtorchaudio/forced_align/gpu/compute.cu#L161-L168

According to earlier lines in the code T is the log_probs length and L is the targets size. https://github.com/pytorch/audio/blob/5286f9f60d8647fb4a490cdf22eac39a54e63a80/src/libtorchaudio/forced_align/gpu/compute.cu#L122-L124

nateanl commented 4 months ago

Thanks @zmolikova for pointing it out. I will make a fix.