search

pytorch / audio

Data manipulation and transformation for audio signal processing, powered by PyTorch
https://pytorch.org/audio
BSD 2-Clause "Simplified" License
2.43k stars 635 forks source link

[codemod] c10::optional -> std::optional in pytorch/audio/src/libtorchaudio/sox/effects.cpp +20 #3791

Closed r-barnes closed 1 month ago

r-barnes commented 1 month ago

Summary: c10::optional was switched to be std::optional after PyTorch moved to C++17. Let's eliminate c10::optional, if we can.

Reviewed By: albanD

Differential Revision: D57294298

pytorch-bot[bot] commented 1 month ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3791

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 8f2bc130dd1688bb5af083cc85299d0f07b0a4ab with merge base ea437b31ce316ea3d66fe73768c0dcb94edb79ad (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D57294298