pytorch / audio

Data manipulation and transformation for audio signal processing, powered by PyTorch
https://pytorch.org/audio
BSD 2-Clause "Simplified" License
2.55k stars 657 forks source link

[codemod] c10::optional -> std::optional in pyspeech/experimental/csrc/decoders/TransducerDecoder.h +20 #3793

Closed r-barnes closed 6 months ago

r-barnes commented 6 months ago

Summary: c10::optional was switched to be std::optional after PyTorch moved to C++17. Let's eliminate c10::optional, if we can.

Reviewed By: albanD

Differential Revision: D57294284

pytorch-bot[bot] commented 6 months ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3793

Note: Links to docs will display an error until the docs builds have been completed.

:x: 2 New Failures

As of commit 9e9ac54f1c318b790f050039bd4764d7cc0bfab3 with merge base ea437b31ce316ea3d66fe73768c0dcb94edb79ad (image):

NEW FAILURES - The following jobs have failed:

* [Build Linux Conda / pytorch/audio / upload / conda-py3_8-cuda12_4](https://hud.pytorch.org/pr/pytorch/audio/3793#24957359276) ([gh](https://github.com/pytorch/audio/actions/runs/9081474520/job/24957359276)) `Unable to find an artifact with the name: pytorch_audio__3.8_cu124_` * [Unit-tests on Linux GPU / tests (3.9, 11.8) / linux-job](https://hud.pytorch.org/pr/pytorch/audio/3793#24955443644) ([gh](https://github.com/pytorch/audio/actions/runs/9081474503/job/24955443644)) `##[error]The operation was canceled.`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 6 months ago

This pull request was exported from Phabricator. Differential Revision: D57294284